Should I lock my suitcase/instrument case for the flight?
No.
Many suitcases and ALL instruments are opened up by security at the airport. If the case is locked, and you are not using a TSA approved lock, they will break the lock, and possibly your suitcase/instrument case.
If you are locking it because you are afraid it might open, use a luggage strap instead.
Posted in: Luggage - Carry On, Traveling with Instruments